Thread (7 messages) flat view 7 messages, 4 authors, 2016-06-15

Re: [PATCH 2/2] completion: split __git_ps1 into a separate script

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:53

Zbigniew Jędrzejewski-Szmek  [off-list ref] writes:
On 05/22/2012 10:46 PM, Felipe Contreras wrote:
quoted
 contrib/completion/git-completion.bash |  257 +---------------------------
 contrib/completion/git-prompt.sh       |  287 ++++++++++++++++++++++++++++++++
 t/t9903-bash-prompt.sh                 |    2 +-
 3 files changed, 290 insertions(+), 256 deletions(-)
 create mode 100644 contrib/completion/git-prompt.sh
Hi,
since git-prompt is not completion related anymore, should a different
directory be used?
I am not sure if that is worth it.  These two share/duplicate some shell
functions and we may end up refactoring them (a way to do so may be to
dot-source git-prompt from git-completion and drop duplicated definitions
from the latter), for example.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help