Re: [PATCHv2 14/15] ident: trim whitespace from default name/email

Jeff King [off-list ref] writes:

On Tue, May 22, 2012 at 09:55:19AM -0700, Junio C Hamano wrote:

quoted

Jeff King [off-list ref] writes:

quoted

... Any other value
comes from a config file, where we will have cleaned up
accidental whitespace already.

Are you referring to the behaviour of the config parser that removes
leading and trailing whitespaces when reading an unquoted string value?

Yes, exactly.

quoted

If the user really wanted to have trailing whitespaces by quoting, we
would let it pass, in other words; it probably is a reasonable behaviour.

Right, that's why I said "accidental" above; you can still do it, but I
think you'd have to be really trying. But I really wonder if we should
be blocking that, too. fmt_ident will drop it anyway, so this is really
only for code paths that want to use the email directly.

Thanks.

quoted

Other than that single small "hrm...", the entire series was a pleasant
read.  Thanks.

Thanks. I'm happy to update this patch if we want it to be more
paranoid, or I can update the commit message if it just needs explained
better.

Neither is necessary. I was just puzzled a bit and was worried if I was
missing something.