[PATCH v2 1/4] cmd_fetch_pack(): declare dest to be const
From: <hidden>
Date: 2016-06-15 22:53:51
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Michael Haggerty <redacted> There is no need for it to be non-const, and this avoids the need for casting away the constness of an argv element. Signed-off-by: Michael Haggerty <redacted> --- builtin/fetch-pack.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index 10db15b..7e9d62f 100644
--- a/builtin/fetch-pack.c
+++ b/builtin/fetch-pack.c@@ -901,7 +901,8 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) { int i, ret, nr_heads; struct ref *ref = NULL; - char *dest = NULL, **heads; + const char *dest = NULL; + char **heads; int fd[2]; char *pack_lockfile = NULL; char **pack_lockfile_ptr = NULL;
@@ -971,7 +972,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) } usage(fetch_pack_usage); } - dest = (char *)arg; + dest = arg; heads = (char **)(argv + i + 1); nr_heads = argc - i - 1; break;
@@ -1018,7 +1019,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) fd[0] = 0; fd[1] = 1; } else { - conn = git_connect(fd, (char *)dest, args.uploadpack, + conn = git_connect(fd, dest, args.uploadpack, args.verbose ? CONNECT_VERBOSE : 0); }
--
1.7.10