Thread (17 messages) flat view 17 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] drop length limitations on gecos-derived names and emails

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:50

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
So it seems to me like a much simpler set of rules would be:

  1. When reading gecos, always fall back to the username if the gecos
     field is unavailable or blank.

  2. Always die when the name field is blank. That means we will die
     when you pass in a bogus empty GIT_COMMITTER_NAME (or an empty
     config name), which makes a lot more sense to me than falling back;
     those are bogus requests, not system config problems.  And we won't
     ever have a blank gecos name, because we'll always fall back on the
     username.
That certainly sounds very simple to explain and understand, and I do not
offhand think of anything *sane* that would break ;-)

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help