Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH/RFC] clone: inform the user we are checking out

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:46

Erik Faye-Lund [off-list ref] writes:
quoted hunk
OK, some blaming shows that this changed in 5bd631b3 ("clone: support
multiple levels of verbosity"), back in February 2010. Before this
patch, one would have to specify the "quiet"-flag to clone to suppress
progress-output, after the patch the default is progress being off.

This seems like the right thing to do if we want to resurrect the
progress-output's default-on behavior:
---8<---
diff --git a/builtin/clone.c b/builtin/clone.c
index 3f863a1..f48e603 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -569,7 +569,7 @@ static int checkout(void)
 	opts.update = 1;
 	opts.merge = 1;
 	opts.fn = oneway_merge;
-	opts.verbose_update = (option_verbosity > 0);
+	opts.verbose_update = (option_verbosity >= 0);
 	opts.src_index = &the_index;
 	opts.dst_index = &the_index;

---8<---
Sounds sensible, as the original said "verbosely update unless we were
told to be quiet", so the normal case should be verbose_update which will
give progress only if it takes too long.

Care to roll a signed-off patch?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help