Re: [PATCH] compat/regex: fix typos in comments.
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:53:45
On Sun, May 6, 2012 at 2:45 PM, Yi, EungJun [off-list ref] wrote:
From: "Yi, EungJun" <redacted> occured => occurred
In d18f76d I changed compat/regex to use the engine from gawk, there
have been a few fixes of ours to it since then, some of which may be
applicable for upstream inclusion:
$ git --no-pager log --oneline --reverse d18f76d.. -- compat/regex
a997bf4 compat/regex: get the gawk regex engine to compile within git
de83172 Change regerror() declaration from K&R style to ANSI C (C89)
b50f370 compat/regex: define out variables only used under RE_ENABLE_I18N
178b331 compat/regex: get rid of old-style definition
ce518bb Fix compat/regex ANSIfication on MinGW
But I don't think we should be taking patches like these. I think they
should instead be sent to the upstream gawk developers who I'm sure
would be happy to take them.
But this is not code that we're maintaining, and patches like these
just make it harder to merge the code from upstream.