Re: [PATCH 5/6] http: Avoid limit of retrying request only twice

On Thu, May 03, 2012 at 06:40:28PM +0200, Nelson Benitez Leon wrote:

Current code, after receiving HTTP_REAUTH, only retried
once, so couldn't do step 3 of the following sequence:

  1. We make a request; proxy returns 407, because we didn't give it a
     password. We ask for the password and return HTTP_REAUTH.

  2. We make another request; the proxy passes it to the actual server,
     who returns 401, because we didn't give an http password. We ask
     for the password and return HTTP_REAUTH.

  3. We make a third request, but this time everybody is happy.

Now we retry as long as we keep receiving HTTP_REAUTH, so the previous
sequence correctly completes.

Patch by Jeff King [off-list ref]

We usually spell that as:

  From: Jeff King [off-list ref]

at the beginning of the email body (which lets am set the author
appropriately).

Other than that, the patch looks good to me (unsurprisingly :) ).

-Peff