Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15
STALE3736d

[PATCH 4/6] http: handle proxy authentication failure (error 407)

From: Nelson Benitez Leon <hidden>
Date: 2016-06-15 22:53:43
Subsystem: the rest · Maintainer: Linus Torvalds

Handle http 407 error code by asking for credentials and
retrying request in case credentials were not present, or
marking credentials as rejected if they were already provided.

Signed-off-by: Nelson Benitez Leon <redacted>
Signed-off-by: Junio C Hamano <redacted>
---
 http.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/http.c b/http.c
index 22ffe0c..c87c66c 100644
--- a/http.c
+++ b/http.c
@@ -879,6 +879,15 @@ static int http_request(const char *url, void *result, int target, int options)
 				init_curl_http_auth(slot->curl);
 				ret = HTTP_REAUTH;
 			}
+		} else if (results.http_code == 407) { /* Proxy authentication failure */
+			if (proxy_auth.username && proxy_auth.password) {
+				credential_reject(&proxy_auth);
+				ret = HTTP_NOAUTH;
+			} else {
+				credential_fill(&proxy_auth);
+				set_proxy_auth(slot->curl);
+				ret = HTTP_REAUTH;
+			}
 		} else {
 			if (!curl_errorstr[0])
 				strlcpy(curl_errorstr,
-- 
1.7.7.6
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help