[PATCH 0/3] Fix some constness errors in fetch-pack and parseopt conversion

On Wed, May 2, 2012 at 8:35 PM, Michael Haggerty [off-list ref] wrote:

On 05/02/2012 01:14 PM, Nguyen Thai Ngoc Duy wrote:

quoted

On Wed, May 2, 2012 at 5:40 PM,[off-list ref]  wrote:

quoted

               const char *arg = argv[i];

-               if (*arg == '-') {
-                       if (!prefixcmp(arg, "--upload-pack=")) {
-                               args.uploadpack = arg + 14;
-                               continue;
-                       }
[...]

Ugh, perhaps you can convert the above to parse_options() too while
you're making changes in this part? You can say no, I'll do it (my
itch anyway).

Sorry, I have too many balls in the air already.  But feel free to veto my
patch if my changes make it harder to switch to parse_options().

No problem. My new patch may slow down your patches to master though.

Michael Haggerty (2):
  cmd_fetch_pack(): declare dest to be const
  cmd_fetch_pack(): fix constness problem and memory leak

Nguyễn Thái Ngọc Duy (1):
  fetch-pack: use parse_options()

 builtin/fetch-pack.c |  138 ++++++++++++++++++++------------------------------
 fetch-pack.h         |   20 ++++----
 2 files changed, 65 insertions(+), 93 deletions(-)

-- 
1.7.8.36.g69ee2