Re: [PATCH 06/10] i18n: remote: mark strings for translation

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 06/10] i18n: remote: mark strings for translation

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:40

Nguyễn Thái Ngọc Duy  [off-list ref] writes:
quoted hunk
@@ -761,7 +761,7 @@ static int remove_branches(struct string_list *branches)
 		unsigned char *sha1 = item->util;
 
 		if (delete_ref(refname, sha1, 0))
-			result |= error("Could not remove branch %s", refname);
+			result |= error(_("Could not remove branch %s"), refname);
 	}
This is an issue in the original, but almost all messages in this
utility use sq around names of 'stuff' that can be specified by the end
user when it appears as part of a sentence, but not here.

Re: [PATCH 06/10] i18n: remote: mark strings for translation

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:53:40

2012/4/26 Junio C Hamano [off-list ref]:
Nguyễn Thái Ngọc Duy  [off-list ref] writes:
quoted
@@ -761,7 +761,7 @@ static int remove_branches(struct string_list *branches)
              unsigned char *sha1 = item->util;

              if (delete_ref(refname, sha1, 0))
-                     result |= error("Could not remove branch %s", refname);
+                     result |= error(_("Could not remove branch %s"), refname);
      }
This is an issue in the original, but almost all messages in this
utility use sq around names of 'stuff' that can be specified by the end
user when it appears as part of a sentence, but not here.
If we are going to make a style consistency patch, should we also
agree on (at least for this command) whether to write initial letter
in capital or not?
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help