Re: What's cooking in git.git (Apr 2012, #09; Mon, 23)

Nelson Benitez Leon [off-list ref] writes:

My original patch already peeked in HTTPS_PROXY env var, I post the
relevant part:
 
+	if (!curl_http_proxy) {
+		const char *env_proxy, *no_proxy;
+		char *env_proxy_var;
+		int read_http_proxy;
+		struct strbuf buf = STRBUF_INIT;
+		credential_from_url(&cre_url, url);
+		strbuf_addf(&buf, "%s_proxy", cre_url.protocol);
+		env_proxy_var = strbuf_detach(&buf, NULL);
+		env_proxy = getenv(env_proxy_var);

                ^^ HERE ^^

When cre_url.protocol is "https", this looks at $ENV{"https_proxy"}, no?

    http://curl.haxx.se/docs/manpage.html#ENVIRONMENT

so are you referring to something else ?

There may be some other things that break people's settings but
regarding PROXY, the above was wnat I was referring to.