Re: [PATCH] Fixed compilation with Visual Studio by including poll.h

On Fri, Apr 20, 2012 at 11:26 PM, Sven Strickroth
[off-list ref] wrote:

Windows does not have sys/poll.h. I have to use the one from compat/win32.

The problem is that
   NO_SYS_POLL_H
is defined in compat/msvc.h in my environment.
And in git-compat-util.h
   #ifndef NO_SYS_POLL_H
   #include <sys/poll.h>
   #else
   #include <poll.h>
   #endif
is before
   #elif defined(_MSC_VER)
   #include "compat/msvc.h"
. Moving it down, solves the issue for me. (Suppose this is a fix for my
scenario only).

NO_SYS_POLL_H shouldn't be defined in compat/msvc.h, it should be
defined by the build-system. Our Makefile already does this inside the
"ifeq ($(uname_S),Windows)"-block.

How are you building Git?