Re: [PATCH v6 4/4] git-rebase: add keep_empty flag

Neil Horman [off-list ref] writes:

quoted

quoted

+is_empty_commit() {
+	tree=$(git rev-parse "$1"^{tree})
+	ptree=$(git rev-parse "$1"^^{tree})
+	return $(test "$tree" = "$ptree")
+}

Could "$1" ever be a root commit without a parent?

Strictly speaking, yes.  If that happens, however, the output of git rev-parse

You do not have to speak strictly to see that bug that surfaces internal
error message leaking to the end user.