Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:37

Johannes Sixt [off-list ref] writes:
Am 4/18/2012 18:30, schrieb Junio C Hamano:
quoted
There is one thing I am confused about your response, though.  I thought
the suggestion by Peff was to build your binary with "make SHELL_PATH=sh"
(not "make SHELL_PATH=/bin/sh").  I do not know if that works or does not
work (I do not see why not, though), but in either case offering a new
customization point sounds like a separate issue.
I tried this, and it does not work. (Shell scripts' shbang line would end
up as '#!sh', and at least bash does not like to run such scripts.)
Ahh, sorry for missing the obvious.  I should have realized about that
one, as customizing that one was the very original motivation of the make
variable.

In any case, as I wrote in the "What's cooking", I'll fast-track the fix
to 'master' shortly, so that Windows port does not have to carry it.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help