Re: [PATCH] rev-parse --show-prefix: add in trailing newline
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:32
Ross Lagerwall [off-list ref] writes:
quoted hunk
diff --git a/t/t1501-worktree.sh b/t/t1501-worktree.sh index e661147..8f36aa9 100755 --- a/t/t1501-worktree.sh +++ b/t/t1501-worktree.sh@@ -68,7 +68,7 @@ test_expect_success 'inside work tree' ' ) ' -test_expect_failure 'empty prefix is actually written out' ' +test_expect_success 'empty prefix is actually written out' ' echo >expected && ( cd work &&
fc68875 (t1501 (rev-parse): clarify, 2010-07-24) says it is a "possible
bug", but I do not think the expectation of the new test added by that
commit is entirely correct.
Because the assignment will strip the trailing LF away adding an extra
newline at the end would not matter in practice in many scripts, e.g.
a=$(git rev-parse --show-prefix)
if test -z "$a"
then
echo we are at toplevel
fi
or
pfx=$(git rev-parse --show-prefix)
cd_to_toplevel
for arg
do
case "$arg" in
/*)
user refers to "$arg" that is a full path ;;
*)
user refers to "$pfx$arg" ;;
esac
done
But it will break existing scripts if they expect the following to work:
file="$(git rev-parse --show-prefix)/$1"
cd_to_toplevel
test -f "$file"