Re: Bad Man Page URLs
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:53:28
Jeff King wrote:
Junio, what do you think of building the git-manpages-* tarballs (and the git-manpages repo) with MAN_BASE_URL set to "http://some-official-place/"? As of now, they mention "file:///home/junio/...".
Could be as simple as this, no? Signed-off-by: Jonathan Nieder <redacted> --- Documentation/Makefile | 10 ++++++++-- Makefile | 1 + 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git i/Documentation/Makefile w/Documentation/Makefile
index d40e211f..0edad3a2 100644
--- i/Documentation/Makefile
+++ w/Documentation/Makefile@@ -248,8 +248,14 @@ $(MAN_HTML): %.html : %.txt $(ASCIIDOC_EXTRA) -agit_version=$(GIT_VERSION) -o $@+ $< && \ mv $@+ $@ -manpage-base-url.xsl: manpage-base-url.xsl.in - sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@ +manpage-base-url.xsl: manpage-base-url.xsl.in FORCE + $(QUIET_GEN)$(RM) $@+ && \ + sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@+ && \ + if test -e $@ && cmp -s $@+ $@; then \ + $(RM) $@+; \ + else \ + mv $@+ $@; \ + fi %.1 %.5 %.7 : %.xml manpage-base-url.xsl $(QUIET_XMLTO)$(RM) $@ && \
diff --git i/Makefile w/Makefile
index be1957a5..ce6f805c 100644
--- i/Makefile
+++ w/Makefile@@ -2623,6 +2623,7 @@ dist-doc: $(RM) -r .doc-tmp-dir mkdir -p .doc-tmp-dir/man1 .doc-tmp-dir/man5 .doc-tmp-dir/man7 $(MAKE) -C Documentation DESTDIR=./ \ + MAN_BASE_URL=git-htmldocs/ \ man1dir=../.doc-tmp-dir/man1 \ man5dir=../.doc-tmp-dir/man5 \ man7dir=../.doc-tmp-dir/man7 \
--