Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] tag: add --author option

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:24

Zbigniew Jędrzejewski-Szmek  [off-list ref] writes:
quoted
+	if (force_author) {
+		const char *lb = strstr(force_author, "<");
+		const char *rb = strchr(force_author, '>');
+
+		if (!lb || !rb)
+			die(_("malformed --author parameter"));
+			name = xstrndup(force_author, lb - force_author);
+			email = xstrndup(lb + 2, rb - (lb + 2));
This part is identical to builtin/commit.c, it would be nice to
refactor it into a function.
Or we may want to use something like split_ident_line() from 4b340cf
(ident.c: add split_ident_line() to parse formatted ident line,
2012-03-11) to consolidate the parsing of this kind of stuff even further.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help