Thread (16 messages) flat view 16 messages, 4 authors, 2016-06-15
STALE3720d

[PATCH] t4052: unset $COLUMNS inherited from environment

From: Zbigniew Jędrzejewski-Szmek <hidden>
Date: 2016-06-15 22:53:23
Subsystem: the rest · Maintainer: Linus Torvalds

$COLUMNS must be unset to not interfere with the tests. The tests
already ignore the terminal size because output is redirected to a
file, but $COLUMNS overrides terminal size detection and changes the
test output away from the standard 80 even if not on a terminal.

Reported-by: Jeff King <redacted>
Signed-off-by: Zbigniew Jędrzejewski-Szmek <redacted>
---
Stupid omission. Please apply.

 t/t4052-stat-output.sh |    1 +
 1 file changed, 1 insertion(+)
diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh
index 328aa8f..1f47f1d 100755
--- a/t/t4052-stat-output.sh
+++ b/t/t4052-stat-output.sh
@@ -17,6 +17,7 @@ test_expect_success 'preparation' '
 	git commit -m message &&
 	echo a >"$name" &&
 	git commit -m message "$name"
+	sane_unset COLUMNS
 '
 
 while read cmd args
-- 
1.7.10.rc1.222.gc0040.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help