Re: [PATCH] gitweb(1) Fixed English issues
From: Thomas Rast <hidden>
Date: 2016-06-15 22:53:22
D Waitzman [off-list ref] writes:
quoted hunk
This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. And then I added it again when he pointed out I missed something in his original email. -- Fixed improper use of "it's" when it should be "its". Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca Signed-off-by: David Waitzman [off-list ref] --- Documentation/gitweb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 605a085..168e8bf 100644
[snip patch]
Note that the correct way to put commentary in the patch mail that does
not go into the commit message is putting it after the --- marker.
Also, we write commit messages in the imperative. The above should
probably look roughly like
Subject: Documentation/gitweb: trivial English fixes
Change "it's" to "its" where a possessive is intended.
Also add two missing "the" that were noticed by Ben Walton
[off-list ref].
Signed-off-by: David Waitzman [off-list ref]
---
This is a trivial patch to correct the english in the man page. Ben
Walton suggested an additional english fix which I have added and
squashed with my change. And then I added it again when he pointed
out I missed something in his original email.
Documentation/gitweb.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
index 605a085..168e8bf 100644
Note that I added "Subject:" here to make it an inline patch (though you
obviously need to remove my extra formatting indent). If there's no
Subject pseudoheader, the patch gets the subject of your email, and
similarly for From and author.
--
Thomas Rast
trast@{inf,student}.ethz.ch