Re: [PATCH] push: Provide situational hints for non-fast-forward errors

Clemens Buchacher [off-list ref] writes:

On Wed, Mar 14, 2012 at 03:27:52PM +0100, Zbigniew Jędrzejewski-Szmek wrote:

quoted

On Wed, Mar 14, 2012 at 02:00:38PM +0100, Matthieu Moy wrote:
...

quoted

The advice messages do not point explicitely to the way to disable them,
so users who know how to set advice.* are users who know a little about
configuration files, and who read the docs. 

Elsewhere in this thread it was proposed to add an actual 'git config'
command to the advice.

The proposed command does not turn off the advice. It only changes
push.default. The advice about push.default is effectively disabled once
they change push.default, but the other warnings are still in effect.

True.

I looked to see if some existing message that is triggered by advice.* has
an extra comment at the end to suggest setting advice.* to false to
decline seeing the advice in the future, as it feels like a sensible thing
to do and also I vaguely recalled us actually doing such a patch, but I do
not seem to be able to find such a message in the current codebase.

Nothing from a quick "git log --no-merges --grep=advice --grep=advise"
pops at me telling that we used to have instructions on how to decline but
we deliberately removed them, so I probably is misremembering things.

We do mention them in git-config(1), but it may be hard to match the
variables to situations from the description there UNLESS the user already
understands what the annoying "I know what I am doing, no need for this
advice anymore" advice is about.

Oh, wait.  Perhaps the advice messages are designed to be declined only by
the user who do understand, so perhaps it is a *good* think that we do not
mention how to squelch in the message.  In a twisted way, the logic sort
of makes sense.

I dunno.