Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:19

Jeff King [off-list ref] writes:
On Thu, Mar 15, 2012 at 09:24:28AM -0400, Jeff King wrote:
quoted
quoted
quoted
quoted
	make GIT_TEST_CREDENTIAL_HELPER=cache T=t0303-*.sh prove

seems to get stuck forever.
It's because t0303 is the generic "test any helper" script, and does not
know how to clean up the credential-cache daemon. So the daemon sticks
around, holding onto a file descriptor that causes prove to hang.
And the reason why "sh t0303-*.sh" version does not have this problem is...?
[long-winded explanation from me]
Oops. I read this as "why does t0301 not have the problem?". So ignore
everything I said.

The reason why running it via sh works is that we leave the daemon
running in both cases, but only prove actually cares about the leaked
file descriptor and blocks.
Ah, OK, the last part was what I was missing.  Thanks for a clarification.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help