Re: [PATCH v2 2/2] index-pack: support multithreaded delta resolving

2012/3/13 Ramsay Jones [off-list ref]:

Nguyễn Thái Ngọc Duy wrote:
[snipped]

quoted

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 I changed Ramsay's mutex patch a little bit and incorporate it here.
 Ramsay, it'd be great if you could try it again on MinGW

Hmm, well do you want the good news, or the bad news ... :-D

First, I should say that I feel like I'm doing a very bad job of
communicating, so let me apologize for that and hope that this time
I make a better job of it!

This patch breaks the build on MinGW, since the emulation code has not
(thus far) included an implementation of pthread_key_delete(). I simply
commented out the call to that function, in cleanup_thread(), so that I
could test the remainder of the patch.

Although this patch is an improvement on previous patches, it still fails
in *exactly* the same way as earlier attempts.

I probably didn't make clear before that 'nr_threads' has been given too
many duties, which is the main reason for me introducing a new variable
'threads_active'. For example, ...

You are right. I will incorporate your changes in the next reroll. Thank you.

[I ran the same four tests as before, five times in a row. On *one* occasion
t5300.22 (verify-pack catches a corrupted type/size of the 1st packed object data)
failed because the 'dd' command crashed! So, maybe there is a problem lurking.]

I fail to see how verify-pack can make dd crash, especially when
verify-pack is called after dd in t5300.22. Anyway it's good to keep
an eye on this case.
-- 
Duy