Thread (11 messages) flat view 11 messages, 4 authors, 2016-06-15

Re: [PATCH] fast-import: fix ls command with empty path

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:53:15

Possibly related (same subject, not in this thread)

Hi,

Junio C Hamano wrote:
So what do you guys want to do with topic?  My gut feeling is that
this is not a new regression and can wait until the next cycle.
Yes, I think you are very right.

. I have a vague fear that my "allow filecopy to copy from root" patch
  on top of David's is missing some handling of the empty src case,
  along the same lines as 8fe533f6 (fast-import: treat filemodify with
  empty tree as delete.

. After looking closer at David's patch, it does not seem to handle
  'ls <tree> ""' carefully enough.  It probably needs something
  like Dmitry's [1].

So please backburner this, and we can try for something better by
next cycle.

Thanks for a sanity check.
Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/179426/focus=179425
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help