Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] fmt-merge-msg: show those involved in a merged series

From: René Scharfe <hidden>
Date: 2016-06-15 22:53:15

Am 07.03.2012 22:59, schrieb Junio C Hamano:
René Scharfe[off-list ref]  writes:
quoted
Am 05.03.2012 22:34, schrieb Junio C Hamano:
quoted
+#define util_as_int(elem) ((intptr_t)((elem)->util))
Something that actually returns an int would fit the name better. ;)
The particular type would not matter to the callers of the helper
macro, would it?
Three of the five callers introduced in that commit cast the result to 
int and the remaining two don't care, so it actually does seem to matter 
for most of them, strictly speaking.  When I see a nit, I can't resist 
the urge to pick it, apparently.

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help