Thread (6 messages) flat view 6 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] rebase -i: optimize the creation of the todo file

From: Dominique Quatravaux <hidden>
Date: 2016-06-15 22:53:15

On Thu, Mar 8, 2012 at 12:20 PM, Johannes Sixt [off-list ref] wrote:
Am 3/8/2012 11:42, schrieb Dominique Quatravaux:
quoted
+     shortsha1=$(echo $sha1 | cut -c1-7)
quoted
-             sha1=$(git rev-parse $shortsha1)
Why do you call it "optimization" when you spend two or three subprocesses
instead of one?
echo is a shell internal. "git rev-parse" is two processes just as
"cut" and a pipe. The difference is that cut doesn't hit the git
repository.

But the real purpose of this first change is to lay the ground for the
next one, so I'd be happy to change the patch description...


-- 
  Dominique Quatravaux
  +41 79 609 40 72
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help