Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15

Re: [PATCH v3 1/3] Fix memory leak in apply_patch in apply.c.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:14

Jared Hance [off-list ref] writes:
In the while loop inside apply_patch, patch is dynamically allocated
with a calloc. However, only unused patches are actually free'd; the
rest are left in a memory leak. Since a list is actively built up
consisting of the used patches, they can simply be iterated and free'd
at the end of the function.
...
Thanks.

This more-or-less looks good modulo minor style issues.  We might
also want to make rejected a one-bit bitfield that sits next to the
new free_patch field to share the same word, but that is a separate
topic.

Will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help