Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/2] perf: compare diff algorithms

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:14

Jakub Narebski [off-list ref] writes:
Beside extracting logic that sets GITPERLLIB into separate file like
in Junio proposal?
That was not even a proposal.  The part that deals with valgrind is
blatantly wrong (it shouldn't create symlinks in that code, it only
should figure out where things should be).
You can always assume that it is fixed relative
to perl/Git.pm, and use __DIR__ or $FindBin to make "use lib", e.g.

  use FindBin;
  use lib "$FindBin::Bin/../../perl";
Use of FindBin to find the location of the script is OK, but does
using "../../perl" really work?

We have this

  GITPERLLIB="$GIT_BUILD_DIR"/perl/blib/lib:"$GIT_BUILD_DIR"/perl/blib/arch/auto/Git

to look for two places in test-lib.sh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help