Re: [PATCH 1/2] perf: compare diff algorithms

Thomas Rast wrote:

Jakub Narebski [off-list ref] writes:

quoted

Junio C Hamano [off-list ref] writes:

quoted

But of course, this from a command line would not work:

	$ perl -MGit

I do not expect it to, and for the ease of testing new versions, I
prefer it not to work.

In any case, you should be able to do anything under t/ _before_
installing, so relying on having Git.pm in normal @INC is a double
no-no.

Thomas, take a look at how it is solved in 't/t9700/test.pl', used by
't/t9700-perl-git.sh':

  use lib (split(/:/, $ENV{GITPERLLIB}));

Hum.  The problem is that the user may invoke aggregate.perl manually,
and GITPERLLIB won't be set in that case.

Is there a better solution than duplicating the logic that sets
GITPERLLIB in test-lib.sh within aggregate.perl?

Beside extracting logic that sets GITPERLLIB into separate file like
in Junio proposal?  You can always assume that it is fixed relative
to perl/Git.pm, and use __DIR__ or $FindBin to make "use lib", e.g.

  use FindBin;
  use lib "$FindBin::Bin/../../perl";

-- 
Jakub Narebski
Poland