Re: [PATCH 2/2] Disambiguate PREFIX define in sideband.c

Vincent van Ravesteijn [off-list ref] writes:

From: Vincent van Ravesteijn <redacted>

PREFIX is already used as the prefix for the system path in system_path(..)
in exec_cmd.c. If PREFIX has been set, this patch prevents a warning that
PREFIX is being redefined.

If I recall correctly -DPREFIX= is given only when compiling that
single file in order to limit the knowledge of the actual value, and
is not given when compiling sideband.c, so it is unclear what
problem you are trying to solve here.

In any case, it probably makes sense to rename _both_ symbols to
make them more descriptive.  In the context of Makefile, PREFIX is
perfectly fine symbol to define the common prefix for installation
path (I would rather see it all in lowercase, but this dates back to
the very original Makefile by Linus), but in the context of the
whole source file, PREFIX doesn't not tell us what kind of prefix it
is about.