Re: [PATCH 1/2] Allow Overriding GIT_BUILD_DIR

Junio C Hamano [off-list ref] writes:

quoted

Right.  This is because you flagged an indentation issue with the
previous version of the patch.  I think what happened is that the
previous version included the 1-HT (what is HT - half-tab?) spacing but
it "looked funny" with the additional "+" from the diff line.

No, with your earlier patch, all the existing lines used horizontal
tabs for indenting, and the line you added used runs of spaces.
When such a hunk is shown in diff output, "+" will make it obvious
that only the new line you added is wrong (because the initial "+"
and " " is absorbed in the first horizontal tab for Tab-indented
lines) and that is how I noticed and pointed out "a funny
indentation" to you.

Hmm...when I went back to the file it indeed had horizontal tabs.  Ah, I
think I know what happened.  I had to cut-n-paste into an e-mail because
I couldn't get git send-email to work at the time (it apparently gives
up after failing to authenticate even if the server presents more than
one authentication method).  So I think the mailer might have replaced
tabs with spaces.  I don't know.  In any case, it's moot.

You indicated you'd fix up the patch.  I am happy to do that as well if
you want a proper re-submission.  Just let me know.

                                    -Dave