Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/2] Allow Overriding GIT_BUILD_DIR

From: David A. Greene <hidden>
Date: 2016-06-15 22:53:13

Junio C Hamano [off-list ref] writes:
Both of your changes seem to have broken indentation to use 8-SP at
the beginning of some (but not all) lines instead 1-HT.  I'll queue
a fixed up version and push the result out in 'pu' later, so please
double check to make sure I didn't screw up.
Right.  This is because you flagged an indentation issue with the
previous version of the patch.  I think what happened is that the
previous version included the 1-HT (what is HT - half-tab?) spacing but
it "looked funny" with the additional "+" from the diff line.

So in some way this was deliberate to make the patch look better.  I
have no problem with you (or me!) changing it back.

Thanks for taking these up!

                          -Dave
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help