Re: [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:12
Jakub Narebski [off-list ref] writes:
The git_project_search_form() subroutine, introduced in a1e1b2d (gitweb: improve usability of projects search form, 2012-01-31) didn't get its arguments from caller correctly. Gitweb worked correctly thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8 fix for project search not working. Signed-off-by: Jakub Narebski <redacted> --- Brown paper bug (a1e1b2d is in master). I am extremly sorry about that.
Heh, mistakes happen. Thanks for taking care of this.
quoted hunk
gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 7398be1..e2e6a73 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -5263,7 +5263,7 @@ sub git_patchset_body { # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . sub git_project_search_form { - my ($searchtext, $search_use_regexp); + my ($searchtext, $search_use_regexp) = @_; my $limit = ''; if ($project_filter) {