Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/4] t5510: ensure we stay in the toplevel test dir

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:11

Thomas Rast [off-list ref] writes:
The last test descended into a subdir without ever re-emerging, which
is not so nice to the next test writer.
True.  Making the test suite more robust like this patch does is very much
appreciated.

Is there a reason why we shouldn't be sticking to the more usual

	mkdir dups &&
        (
        	cd dups &&
                do whatever in dups
	)

pattern?
quoted hunk
Signed-off-by: Thomas Rast <redacted>
---
 t/t5510-fetch.sh |    1 +
 1 file changed, 1 insertion(+)
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index 8827828..dd035bf 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -431,6 +431,7 @@ test_expect_success 'fetch --dry-run' '
 test_expect_success "should be able to fetch with duplicate refspecs" '
 	mkdir dups &&
 	cd dups &&
+	test_when_finished "cd .." &&
 	git init &&
 	git config branch.master.remote three &&
 	git config remote.three.url ../three/.git &&
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help