Re: [PATCH v3] Documentation fixes in git-config
From: Jeff King <hidden>
Date: 2016-06-15 22:53:11
On Thu, Mar 01, 2012 at 09:19:42AM +0100, Libor Pechacek wrote:
Variable names must start with an alphabetic character, regexp config key matching has its limits. [...] This patch has fallen through the cracks, therefore I re-send it. Previous discussion about this patch is at http://www.spinics.net/lists/git/msg149593.html. The only change I've done since version 2 of this patch is replacing apostrophes with backticks in the first hunk.
Wow, it's been a while. :) Generally it looks OK to me, but I have two comments:
quoted hunk ↗ jump to hunk
Syntax ~~~~~~@@ -54,9 +55,10 @@ All the other lines (and the remainder of the line after the section header) are recognized as setting variables, in the form 'name = value'. If there is no equal sign on the line, the entire line is taken as 'name' and the variable is recognized as boolean "true". -The variable names are case-insensitive and only alphanumeric -characters and `-` are allowed. There can be more than one value -for a given variable; we say then that variable is multivalued. +The variable names are case-insensitive, allow only alphanumeric characters +and `-`, and must start with an alphabetic character. There can be more +than one value for a given variable; we say then that variable is +multivalued.
Not an error you introduced, but should it be "...we say then that _the_ variable is multivalued".
quoted hunk ↗ jump to hunk
diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index aa8303b..a54fee8 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt@@ -85,8 +85,13 @@ OPTIONS is not exactly one. --get-regexp:: - Like --get-all, but interprets the name as a regular expression. - Also outputs the key names. + Like --get-all, but interprets the name as a regular expression and + writes out the key names. Regular expression matching is currently + case-sensitive and done against a canonicalized version of the key + in which section and variable names are lowercased, but subsection + names are not. Regular expressions are partially lower-cased + before matching (everything before the first dot and after the last + dot), which makes things like "Core.*' work.
I know I ack'ed this last time around, but reading it fresh, I think we are probably better off to just not mention the down-casing at all. It's just confusing, and people shouldn't depend on it. They should know that they are comparing against the canonical name, and should use lowercase in their regex. I.e., just cut out the last sentence from there. -Peff