Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] commit: allow {--amend|-c foo} when {HEAD|foo} has empty message

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:10

Thomas Rast [off-list ref] writes:
So either there's a lot to be fixed, or fsck needs to catch this.
Your experiment with hash-object aside (that is like saying "I can write
garbage with a disk editor, and now OS cannot read from that directory"),
if somebody manages to create a commit without any body, it is clear that
the user wanted to record no body.  I think all code that tries to run
strstr("\n\n") and increment the resulting pointer by two to find the
beginning of the body should behave as if it found one and the result
pointed at a NUL.  Rejecting with fsck does not help anybody, as it
happens after the fact.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help