Re: [PATCH] cherry-pick -x: always insert an empty line

On 19.02.2012 09:44, Junio C Hamano wrote:

If we cherry pick your commit somewhere else with "-x -s", the resulting
commit log message would end like this:

     Aside from that, even with a non-trivial commit the generated note
     "(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)"
     seems abrupt when appended directly.

     Cc: Eric Raible[off-list ref]
     Signed-off-by: Beat Bolli[off-list ref]

     (cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)
     Signed-off-by: Frotz Xyzzy[off-list ref]

which clearly is worse-looking with the extra LF you added in this patch.

Clearly? I would not say so, on the contrary. When using -s together 
with -x, I'd interpret this as signing off the process of cherry-picking 
itself, and as such, visually grouping the additional "signed-off" with 
the "cherry picked from" makes sense to me.

-- 
Sebastian Schuberth