Re: [RFC/PATCH 2/3] remote: reorganize check_pattern_match()

Felipe Contreras [off-list ref] writes:

quoted

For a change that not just adds parameters but removes an existing one,
this is way under-described with neither in-code comment nor log message.

But it doesn't. src is renamed to ref.

That is exactly why I mentioned that this is a "chance" in the part of my
message you did not quote ;-).

It was a chance for you to learn how the thought process of others may
work or not work well, depending on how well the log message at the top
prepares their mind before they start to read the patch, by looking at how
one reader (me) tried to figure your patch out.

Anything that I said in the message you are responding to that tempts you
to say "No you are reading wrong" is an indication that the patch did not
do a good job to help the reader understand what you wanted to do.