Re: [PATCH v2] Add a setting to require a filter to be successful

Johannes Sixt [off-list ref] writes:

Am 2/17/2012 2:19, schrieb jehan@orb.com:

quoted

@@ -747,13 +753,19 @@ int convert_to_git(const char *path, const char *src, size_t len,

...

quoted

 	ret |= apply_filter(path, src, len, dst, filter);
+	if (!ret && required)
+		die("required filter '%s' failed", ca.drv->name);

Wouldn't it be much more helpful if this were:

	die("%s: clean filter '%s' failed", path, ca.drv->name);

Likewise (with s/clean/smudge/) in convert_to_working_tree_internal().

quoted

+	! git checkout -- test.fs

	test_must_fail git checkout -- test.fs

quoted

+	! git add test.fc

	test_must_fail git add test.fc

-- Hannes

Thanks; I'll just squash these in in-place.