Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] git-svn: Fix time zone in --localtime

From: Wei-Yin Chen (陳威尹) <hidden>
Date: 2016-06-15 22:53:03

On 2012-02-12 16:15, Eric Wong wrote:
quoted hunk ↗ jump to hunk
I needed the following additional change to get things working:
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -6111,7 +6111,7 @@ sub run_pager {

  sub format_svn_date {
  	my $t = shift || time;
-	my $gmoff = get_tz($t);
+	my $gmoff = Git::SVN::get_tz($t);
  	return strftime("%Y-%m-%d %H:%M:%S $gmoff (%a, %d %b %Y)", localtime($t));
  }
Sorry, my bad. This bug of missing package reference can be triggered by 
"git svn log", but unfortunately I didn't test this part manually. I'll 
learn to use the git test suite next time.
If there are no objections, I'll squash this and push for Junio
tomorrow.
Excellent. Thank you for the testing and fixing effort!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help