Thread (61 messages) flat view 61 messages, 3 authors, 2016-06-15

Re: [PATCH 7/8] gitweb: Use different colors to present marked changes

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:53:03

Michał Kiedrowicz [off-list ref] writes:
This makes use of the highlight diff feature.

Signed-off-by: Michał Kiedrowicz <redacted>
---
I decided to split mechanism (generate HTML page with <span> elements that
mark interesting fragments of diff output) from politics (use these
particular colors for this <span> elements), but otherwise this commit
may be squashed with the previous one. These colors work for me but if
someone comes out with better ones, I'd be happy.
I think it would be better squashed with previous patch, otherwise it
is a bit not visible change...
 
quoted hunk ↗ jump to hunk
 gitweb/static/gitweb.css |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
index c7827e8..4f87d16 100644
--- a/gitweb/static/gitweb.css
+++ b/gitweb/static/gitweb.css
@@ -438,6 +438,10 @@ div.diff.add {
 	color: #008800;
 }
 
+div.diff.add span.marked {
+	background-color: #77ff77;
+}
+
 div.diff.from_file a.path,
 div.diff.from_file {
 	color: #aa0000;
@@ -447,6 +451,10 @@ div.diff.rem {
 	color: #cc0000;
 }
 
+div.diff.rem span.marked {
+	background-color: #ff7777;
+}
+
 div.diff.chunk_header a,
 div.diff.chunk_header {
 	color: #990099;
-- 
I'd have to see those colors in use.  BTW what colors other
highlighting diff GUIs use?

-- 
Jakub Narębski
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help