Re: [PATCHv3] tag: add --points-at list option

On Wed, Feb 08, 2012 at 10:43:32AM -0800, Tom Grennan wrote:

On Wed, Feb 08, 2012 at 10:44:42AM -0500, Jeff King wrote:

quoted

On Tue, Feb 07, 2012 at 10:21:16PM -0800, Tom Grennan wrote:

Also, should we be producing an error if !obj? It would indicate a tag
that points to a bogus object.

I think the test of (obj) is redundant as this should be caught
by get_sha1() in parse_opt_points_at()

I'm wrong. That tests the sha of the point-at argument, not the
sha/objects of the refs/tags entry.  I'll add...

	if (!obj)
		die(_("invalid tag, 'refs/tags/%s'"), refname);

-- 
TomG