Re: [bug] blame duplicates trailing ">" in mailmapped emails

Felipe Contreras [off-list ref] writes:

This subject doesn't explain the *purpose* of the patch: always return
a plain mail address from map_user()

That would be a much better subject.

I think the immediate problem should be here:

Currently 'git blame -e' would add an extra '>' if map_user() returns
true, which would end up as '[off-list ref]>'. This is because
map_user() sometimes modifies, the mail string, but sometimes not. So
let's always modify it.

That is just a symptom.  People who reached this commit by digging the
history of mailmap.c would need to see the *cause* of the symptom
described in the light of how the API is designed to be used.  In other
words, "the code after the update has to be this way because these are the
i/o constraints this API has".  "Otherwise you would see this breakage for
example" is merely a supporting material.