Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 0/2] config includes, take 2

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:00

Jeff King [off-list ref] writes:
... But the point of
duplicate suppression was that individual config files wouldn't have to
know or care what was being included elsewhere.
I think you wanted to say "the point of inclusion mechanism" is that
individual configuration files would not have to know, and I think I
agree.
So I'm actually thinking I should drop the duplicate suppression and
just do some sort of sanity check on include-depth to break cycles
(i.e., just die because it's a crazy thing to do, and we are really just
trying to tell the user their config is broken rather than go into an
infinite loop). As a bonus, it makes the code much simpler, too.
Yeah, I stand corrected. It was a bad suggestion.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help