Re: [PATCH v4 08/13] column: add column.ui for default column output settings
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:56
Nguyễn Thái Ngọc Duy [off-list ref] writes:
quoted hunk
diff --git a/column.h b/column.h index 1912cb0..afdafc4 100644 --- a/column.h +++ b/column.h@@ -17,6 +17,8 @@ struct column_options { const char *nl; }; +extern int git_colopts;
For a global state variable, I'd prefer to see it spelled out, e.g. git_column_opts or even git_column_options. It's not like you would be referring to this variable from everywhere---you would use it only from fallback codepaths after parse_options() returns, or something, no?