Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] t0300-credentials: Word around a solaris /bin/sh bug

From: Ben Walton <hidden>
Date: 2016-06-15 22:52:56

Excerpts from Jeff King's message of Fri Feb 03 16:55:07 -0500 2012:
quoted
    write_script () {
        case "$#" in
        1)    case "$1" in
            *.perl | *.pl) echo "#!$PERL_PATH" ;;
            *) echo "#!$SHELL_PATH" ;;
            esac
                2)    echo "#!$2" ;;
        *)    BUG ;;
                esac >"$1" &&
                cat >>"$1" &&
                chmod +x "$1"
    }
Nice. I was going to suggest a wrapper like "write_sh_script" so you
didn't have to spell out $SHELL_PATH, but I think the auto-detection
makes sense (and falling back to shell makes even more sense, as that
covers 99% of the cases anyway).
This looks like a very nice, general purpose, solution to the problem.

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help