Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH/RFCv2 (version B)] gitweb: Allow UTF-8 encoded CGI query parameters and path_info

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:56

Jakub Narebski [off-list ref] writes:
Gitweb tries hard to properly process UTF-8 data, by marking output
from git commands and contents of files as UTF-8 with to_utf8()
subroutine.  This ensures that gitweb would print correctly UTF-8
e.g. in 'log' and 'commit' views.

Unfortunately it misses another source of potentially Unicode input,
namely query parameters.  The result is that one cannot search for a
I think two lines should suffice instead of the above two paragraphs.

        Gitweb forgot to turn query parameters into UTF-8. This results in
        a bug that one cannot search for a
string containing characters outside US-ASCII.  For example searching
...
The remainder explains the problem and the solution very well modulo minor
typos.
Noticed-by: Michał Kiedrowicz [off-list ref]
Signed-off-by: Jakub Narębski <redacted>
---
We can add "Tested-by:" to this now.  Will queue.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help