Thread (29 messages) flat view 29 messages, 1 author, 2016-06-15
STALE3718d

[PATCH v4 05/13] Stop starting pager recursively

From: Nguyễn Thái Ngọc Duy <hidden>
Date: 2016-06-15 22:52:55
Subsystem: the rest · Maintainer: Linus Torvalds

git-column can be used as a pager for other git commands, something
like this:

    GIT_PAGER="git -p column --mode='dense color'" git -p branch

The problem with this is that "git -p column" also has $GIT_PAGER
set so the pager runs itself again as a pager, then again and again.

Stop this.

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 pager.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/pager.c b/pager.c
index 772a5a6..e4353dc 100644
--- a/pager.c
+++ b/pager.c
@@ -89,7 +89,7 @@ void setup_pager(void)
 	const char *pager = git_pager(isatty(1));
 	int width;
 
-	if (!pager)
+	if (!pager || pager_in_use())
 		return;
 
 	setenv("GIT_PAGER_IN_USE", "true", 1);
-- 
1.7.8.36.g69ee2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help