Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] merge: add instructions to the commit message when editing

From: Thomas Rast <hidden>
Date: 2016-06-15 22:52:53

Junio C Hamano [off-list ref] writes:
Thomas Rast [off-list ref] writes:
quoted
quoted
  Please enter the commit message for your merge commit.  Explain
  why the merge is necessary, especially if it merges an updated
  upstream into a topic branch.

... because people who need to be told to "justify it" would probably be
helped by a more explicit "explain _why_ it is needed".
Why not.  The "explain..." might be construed as a bit too coercive, but
I cannot come up with a way to defuse it (well, except again tacking on
"you should") ...
Would "Please enter the commit message for your merge commit, to explain
why ..." work?
Yes, though it winds up as a rather long sentence.  I could then shorten
it to

  Please enter a commit message that explains why the merge commit is
  necessary, especially if it merges an updated upstream into a topic
  branch.

though that's only _implying_ that you're completing a merge.

Your pick ;-)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help