Thread (5 messages) 5 messages, 2 authors, 2016-06-15

Re: [PATCH v2 4/4] completion: be nicer with zsh

flat view

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:52:53

Felipe Contreras wrote:
The commands might fail, that's why '2> /dev/null' was used before,
and ':' is used right now.
Wait, what?

: is a no-op command.  It does not redirect stderr automatically or
do any other magical thing.

[...]
And IMO harder to read. But you are correct that most of the code uses
[[]], which I think is a shame. But I guess people want to keep using
that.
[[ has simpler syntax wrt quoting and other details.  But now that I
check, the code uses [ a lot, too (which, like "test", is a plain
built-in command), so I suppose consistency is the only reason to
prefer one over another.  "git log --grep='if \['" tells me the use of
'[' instead of 'test' here is deliberate.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help