Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] git-sh-i18n: detect and avoid broken gettext(1) implementation

From: Alex Riesen <hidden>
Date: 2016-06-15 22:52:50

Possibly related (same subject, not in this thread)

On Fri, Jan 20, 2012 at 21:00, Junio C Hamano [off-list ref] wrote:
IOW, the first step would look like the attached patch, and then we can
replace the entire "First decide" part if/elif/fi chain with just this:

       # The scheme to use
       : ${GIT_INTERNAL_GETTEXT_SH_SCHEME:=@@GETTEXT_SH_SCHEME@@}

so that t/lib-gettext.sh can define and export GIT_INTERNAL_GETTEXT_SH to
always get what it wants to test (fallthrough?). At build time, instead
of, or in addition to, the $(cmd_munge_script), we could replace the
single @@GETTEXT_SH_SCHEME@@ token above with whatever scheme we want to
use to hardcode the decision we make at the compile time.
I can imagine a Solaris system being upgraded to GNU gettext _after_ Git
installation. Hardcoding the decision might break git scripts then.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help